New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly replace git-conventional with conventional-commit-parser #28
Comments
I had a look at your library and I think Let me know if I can help with anything else :) |
@oknozor Any thoughts on collaborating? I will admit, I've had bad experiences in the past with pest and much prefer nom. Unsure if that will be a deal breaker or not. I am working with the nom maintainers to improve its readability. |
@epage I'd be glad to contribute if needed, but I have never used nom before. Also regarding your experience with pest this issue might be interesting. When I made conventional-commit-parser I was not aware about git-conventional. I have just made a quick poc to migrate from git-conventional to conventional-commit-parser. Turns out the API is 95% similar (you can see the diff here), so like I said before I would be happy to drop conventional-commit-parser and use git-conventional. There is one thing that puzzle me though : In the migration attempt I made the main test is failing :
All commit are parsed correctly but one is not displayed in the final output, I was not able to find why. I'd be curious to know what is causing this. @orhun any idea ? I will try switching to git-conventional on cocogitto's side and let you know how it goes. |
That describes the biggest issue I have with pest (my equivalent post for nom). The slightly less important one is I'm not happy with is the compile times from being a proc-macro doing code-gen. |
It seems like this commit is not processed:
Support for these types of commits was added with #8. You can check out the implementation here. Maybe there is an API difference between two libraries. edit: this change seems like the issue: oknozor@7088bc6#diff-fb8ea8d3a2eea059cc2540308b82d45fd5194ec545a113394ea3a75bcba3bad1R148 |
I think you can close this now, just so you now I tried integrating both git-conventional and the latest conventional-commit-parser in cocogitto. |
Is your feature request related to a problem? Please describe.
Hi @orhun
This is not directly related to git-cliff, as you know I am refactoring the cocogitto changelog logic to use git-cliff internals.
Now I am facing the following dilemma :
cocogitto uses conventional_commit_parser, git-cliff uses git-conventional which does exactly the same.
In order to integrate git-cliff I need either to use git-conventional and drop conventional_commit_parser or do the opposite in
git-cliff.
Describe the solution you'd like
I am biased toward the library I wrote but I think it has a few cons :
If you are ok with this I can make a draft PR in git-cliff.
Describe alternatives you've considered
If you have some good reason to stick with git conventional I'll refactor on cocogitto's side to get this done. Let me know.
The text was updated successfully, but these errors were encountered: