Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP-4490, reducing gas cost prior to the Merge #4490

Closed

Conversation

louisguthmannStarkWare
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

louisguthmannStarkWare and others added 24 commits May 14, 2020 14:22
…d to EIP-2645 - Hierarchical Deterministic Wallet for CIP Layer-2.md
…r-2.md

Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
I just saw a small change that was not actualized on this EIP. It also simplifies the value
Sorry, I made a typo in the previous commit
Co-authored-by: Micah Zoltu <micah@zoltu.net>
@eth-bot
Copy link
Collaborator

eth-bot commented Nov 24, 2021

A critical exception has occured (cc @alita-moore):
Message: can not read a block mapping entry; a multiline key may not be an implicit key at line 4, column 7:
author: tom brand (tom@starkware.co), ...
^

@louisguthmannStarkWare louisguthmannStarkWare changed the title EIP-4445, reducing gas cost prior to the Merge EIP-4490, reducing gas cost prior to the Merge Nov 24, 2021
@@ -1,9 +1,15 @@
---
eip: 2645
title: Hierarchical Deterministic Wallet for Layer-2
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these changes.

---
eip: 4490
title: Second transaction data gas cost reduction
authors: Louis Guthmann <louis@starkware.co>, Philippe Castonguay <ph.castonguay@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use a GitHub username for at least one author.

eip: 4490
title: Second transaction data gas cost reduction
authors: Louis Guthmann <louis@starkware.co>, Philippe Castonguay <ph.castonguay@gmail.com>
discussions-to: XXX
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mandatory field.

created: 2021-11-23
---

## Simple Summary
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been superseded by the description: preamble.

Copy link
Member

@axic axic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the current EIP template (and EIP-1):

  • Missing description: preamble
  • Missing GitHub username
  • Missing discussion-url:
  • Missing sections: Abstract, Rationale, Backwards Compatibility, Security Considerations
  • Not needed sections: Test Cases, Reference Implementation
  • References is a non-standard section and likely the content needs to be integrated differently (various editors have differing views on external links)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants