New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-4490, reducing gas cost prior to the Merge #4490
EIP-4490, reducing gas cost prior to the Merge #4490
Conversation
…d to EIP-2645 - Hierarchical Deterministic Wallet for CIP Layer-2.md
…r-2.md Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
Co-authored-by: Alex Beregszaszi <alex@rtfs.hu>
I just saw a small change that was not actualized on this EIP. It also simplifies the value
Sorry, I made a typo in the previous commit
Co-authored-by: Micah Zoltu <micah@zoltu.net>
A critical exception has occured (cc @alita-moore): |
@@ -1,9 +1,15 @@ | |||
--- | |||
eip: 2645 | |||
title: Hierarchical Deterministic Wallet for Layer-2 | |||
<<<<<<< HEAD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove these changes.
--- | ||
eip: 4490 | ||
title: Second transaction data gas cost reduction | ||
authors: Louis Guthmann <louis@starkware.co>, Philippe Castonguay <ph.castonguay@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to use a GitHub username for at least one author.
eip: 4490 | ||
title: Second transaction data gas cost reduction | ||
authors: Louis Guthmann <louis@starkware.co>, Philippe Castonguay <ph.castonguay@gmail.com> | ||
discussions-to: XXX |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mandatory field.
created: 2021-11-23 | ||
--- | ||
|
||
## Simple Summary |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been superseded by the description:
preamble.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at the current EIP template (and EIP-1):
- Missing
description:
preamble - Missing GitHub username
- Missing
discussion-url:
- Missing sections: Abstract, Rationale, Backwards Compatibility, Security Considerations
- Not needed sections: Test Cases, Reference Implementation
- References is a non-standard section and likely the content needs to be integrated differently (various editors have differing views on external links)
When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md
We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met: