I think making all elections partisan makes sense, but I also think that it makes candidates from the dominant party more likely to win and candidates from the minority party less likely to win, so we'd be gaining more dominance in already blue-leaning states in exchange for even fewer wins in red states. I think that's alright, because there's a positive good in giving people more information to help them choose a candidate, but it's worth noting. It's also problematic to have to pick candidates for judgeships and Attorneys General on a partisan basis, but we definitely do have to do that at this point in American history!