The app for independent voices

Here is an honest question that got me in trouble at work:

“Are code reviews supposed to be like proofreading a paper, where you are allowed to choose which suggestions to use and which you will disregard, or are they like a gate where the reviewers are the gatekeepers and every suggestion must be incorporated before the code is accepted?”

Management thought this question was inappropriate, because it “assumes that we aren't all on the same team.” I thought my question was fair, because it's only natural for people to disagree in which case you need to have a way to determine who “wins.” When I used the word “win,” it really set management off.

What's your take?

Oct 25, 2024
at
2:28 PM

Log in or sign up

Join the most interesting and insightful discussions.